Discussion:
[Btrfs-devel] [PATCH] btrfs-progs build fails with warnings on 32-bit
Nikanth Karthikesan
2008-03-26 05:18:09 UTC
Permalink
fix for build failure on 32-bit with warnings

Signed-off-by: Nikanth Karthikesan <***@suse.de>

---


diff -r 78036b899594 btrfsck.c
--- a/btrfsck.c Tue Mar 25 16:50:20 2008 -0400
+++ b/btrfsck.c Wed Mar 26 12:18:21 2008 +0530
@@ -134,7 +134,7 @@ static int check_leaf(struct btrfs_root
BTRFS_LEAF_DATA_SIZE(root)) {
fprintf(stderr, "bad item end %u wanted %lu\n",
btrfs_item_end_nr(buf, i),
- BTRFS_LEAF_DATA_SIZE(root));
+ (unsigned long) BTRFS_LEAF_DATA_SIZE(root));
return 1;
}
}
diff -r 78036b899594 btrfsctl.c
--- a/btrfsctl.c Tue Mar 25 16:50:20 2008 -0400
+++ b/btrfsctl.c Wed Mar 26 12:30:19 2008 +0530
@@ -137,7 +137,8 @@ int main(int ac, char **av)
fd = dirfd(dirstream);
} else if (command == BTRFS_IOC_SCAN_DEV) {
fd = open("/dev/btrfs-control", O_RDWR);
- printf("scanning %s command %lu\n", fname, BTRFS_IOC_SCAN_DEV);
+ printf("scanning %s command %lu\n", fname,
+ (unsigned long) BTRFS_IOC_SCAN_DEV);
name = fname;
} else {
fd = open(fname, O_RDWR);
Chris Mason
2008-03-26 11:17:26 UTC
Permalink
Post by Nikanth Karthikesan
fix for build failure on 32-bit with warnings
Thanks, this looks like it is on the unstable tree, have you done larger
testing on 32 bit yet?

-chris
Nikanth K
2008-03-28 03:11:58 UTC
Permalink
Post by Chris Mason
Post by Nikanth Karthikesan
fix for build failure on 32-bit with warnings
Thanks, this looks like it is on the unstable tree, have you done larger
testing on 32 bit yet?
Yes, this is against unstable tree. I haven't done much of testing of late.
But this was working fine on 32-bit.

Loading...